On 17.07.2015 18:50, Will Deacon wrote: > On Fri, Jul 17, 2015 at 05:02:13PM +0100, Andre Przywara wrote: >> clang by default doesn't seem to like printf calls with non-literal >> format strings. >> Add the proper pragma to disable this warning in the report function >> to make kvmtool compile with clang. Despite its GCC name, clang also >> accepts this. >> >> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> >> --- >> util/util.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/util/util.c b/util/util.c >> index 1877105..825da3f 100644 >> --- a/util/util.c >> +++ b/util/util.c >> @@ -10,6 +10,7 @@ >> #include <sys/stat.h> >> #include <sys/statfs.h> >> >> +#pragma GCC diagnostic ignored "-Wformat-nonliteral" > > Urgh! I think we need to figure out a better way to keep clang happy in > this regard, if we decide that we care about building with it. > > Will > _______________________________________________ > kvmarm mailing list > kvmarm@xxxxxxxxxxxxxxxxxxxxx > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm > Hi, what about adding -Wno-format-nonliteral to the CFLAGS when compiling with clang? This could be set up by configure script or equivalent mechanism, ..? Ciao, Claudio -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
