Re: [kvm-unit-tests PATCH 1/7] READ: add some CONTRIBUTING notes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



$SUBJECT is missing the 'ME' in README, but no biggy...

On Fri, Jul 03, 2015 at 02:48:41PM +0100, Alex Bennée wrote:
> Signed-off-by: Alex Bennée <alex.bennee@xxxxxxxxxx>
> ---
>  README | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/README b/README
> index e9869d1..4001456 100644
> --- a/README
> +++ b/README
> @@ -25,3 +25,25 @@ Directory structure:
>  ./<ARCH>:	the sources of the tests and the created objects/images
>  
>  See <ARCH>/README for architecture specific documentation.
> +
> +CONTRIBUTING:
> +=============
> +
> +Style
> +-----
> +
> +  - C: please use standard linux-with-tabs
> +  - Shell: use TABs for indentation

This is (unfortunately) not globally true. We have plenty of
lib/ and x86/ code that don't follow this style. Maybe we should
bite the bullet and fix those someday. Or, add a line to this README
that says, 'use the style of the file for consistency'.

> +
> +Patches
> +-------
> +
> +Patches are welcome at the KVM mailing list <kvm@xxxxxxxxxxxxxxx>.
> +
> +Please prefix messages with: [kvm-unit-tests PATCH]
> +
> +You can add the following to .git/config to do this automatically for you:
> +
> +[format]
> +	subjectprefix = kvm-unit-tests PATCH
> +

This is good to document.

Thanks,
drew
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux