On 03/07/15 12:55, Eric Auger wrote: > Christoffer, Marc, > On 07/02/2015 03:17 PM, Eric Auger wrote: >> On halt, the guest is forced to exit and prevented from being >> re-entered. This is synchronous. >> >> Those two operations will be needed for IRQ forwarding setting. >> >> Signed-off-by: Eric Auger <eric.auger@xxxxxxxxxx> > would you agree to handle this ARM functionality separately from the > forwarding series? > > This includes 2 patch files, that one + > https://lkml.org/lkml/2015/7/2/288. This functionality is needed for > forwarding control since when changing the forwarding state we need to > "freeze" the state of the physical/virtual IRQ to undertake proper > actions. Stopping the guest makes sure it won't deactivate the virtual > IRQ while we are doing state change actions. > > The forwarding series is quite heterogeneous (VFIO platform driver, > vgic, irq bypass manager) and I think it would simplify the review process. > > Please let me know if you agree. If yes, I will post a separate series. I don't mind, I trust you to do what's best for these series to be easily reviewed (if that is at all possible). The only thing is that this patch implements a feature that will otherwise be unused, so annotating the functions with __maybe_unused would avoid warnings. Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
