Dong, Eddie wrote:
Kernel pio emulation return value is mistakenly checked, fortuantely it is not hit yet for normal OS bootup :(
diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index ca91749..0edd2e7 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -1838,7 +1838,7 @@ special_insn:
io_dir_in = 0;
do_io: if (kvm_emulate_pio(ctxt->vcpu, NULL, io_dir_in,
(c->d & ByteOp) ? 1 : c->op_bytes,
- port) != 0) {
+ port) == 0) {
c->eip = saved_eip;
goto cannot_emulate;
}
kvm_emulate_pio() returns 1 when emulation is complete, and 0 when
emulation needs further processing in userspace. So I think in both
cases cannot_emulate is the wrong answer. I think 'in' emulation gets
it right.
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
