Hello! > > Given API change i suggest (using KVM_MSI_VALID_DEVID flag), we could get rid of all these if()'s > > here. Just forward all parameters to vGIC implementation code and let it do its checks. > I don't understand this comment. Here this is the kernel struct that is > used (struct kvm_kernel_irq_routing_entry) and not the user one > (kvm_irq_routing_entry). The kernel struct does not have the flag field. Easy. ARM code can always use struct kvm_extended_msi, and flags can go to this structure. > Another reason I think to keep using the type for homogeneity. Homogeneity is perfect IMHO. If that would be simpler for you, i could post a patch for this which i made on top of your series. Sorry, i don't have time to respin the whole thing, busy with qemu GICv3 fight :) Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
