If userspace is controlling the crash capabilities then HV_X64_MSR_CRASH_CTL_CONTENTS is not needed. On Wed, Jul 1, 2015 at 8:53 AM, Denis V. Lunev <den@xxxxxxxxxx> wrote: > On 01/07/15 18:00, Paolo Bonzini wrote: >> >> >> On 30/06/2015 13:33, Denis V. Lunev wrote: >>> >>> +#define HV_X64_MSR_CRASH_CTL_NOTIFY (1ULL << 63) >>> +#define HV_X64_MSR_CRASH_CTL_CONTENTS \ >>> + (HV_X64_MSR_CRASH_CTL_NOTIFY) >> >> Why is HV_X64_MSR_CRASH_CTL_CONTENTS needed? Can I just remove it? >> >> Paolo > > this was a direct request from Peter Hornyack <peterhornyack@xxxxxxxxxx> > > "I suggest here: > > #define HV_X64_MSR_CRASH_CTL_CONTENTS \ > (HV_CRASH_CTL_CRASH_NOTIFY) > > To allow for more crash actions to be added in the future." > > Den -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html