On 12/06/2015 16:51, Alex Williamson wrote: > > > The code below can't get to this function without > > > __KVM_HAVE_ARCH_KVM_VFIO_POST, but this seems like it should return an > > > error if not implemented. > > > > kvm_arch_vfio_update_pi_irte() is called by kvm_vfio_control_pi(), if we remove the > > dummy definition of kvm_arch_vfio_update_pi_irte(), kvm_vfio_control_pi() is also > > needed to be included in __KVM_HAVE_ARCH_KVM_VFIO_POST, I will handle this > > in the next version. > > But typically we wouldn't return success for a function that's not > implemented. I agree. Moving the implementation to vmx.c would also let you make kvm_arch_update_pi_irte() the only entry-point to the functionality in vmx.c. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
