Re: [PATCH V5 2/4] KVM: x86/vPMU: Create vPMU interface for VMX and SVM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 12/06/2015 07:34, Wei Huang wrote:
> -static void trigger_pmi(struct irq_work *irq_work)
> +static void kvm_pmi_trigger_fn(struct irq_work *irq_work)
>  {
> -	struct kvm_pmu *pmu = container_of(irq_work, struct kvm_pmu,
> -			irq_work);
> -	struct kvm_vcpu *vcpu = container_of(pmu, struct kvm_vcpu,
> -			arch.pmu);
> +	struct kvm_pmu *pmu = container_of(irq_work, struct kvm_pmu, irq_work);
> +	struct kvm_vcpu *vcpu = pmu_to_vcpu(pmu);
>  
> -	kvm_deliver_pmi(vcpu);
> +	kvm_pmu_deliver_pmi(vcpu);
>  }
>  

On the other hand, this patch really should have been split further.

For example, just looking at this snippet you can see that the
introduction of pmu_to_vcpu and the function renames should have been
separate from the creation of the vPMU interface.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux