Re: [PATCH] do not free active mmu pages in free_mmu_pages()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 16, 2009 at 11:20:10PM +0200, Gleb Natapov wrote:
> > mmu_lock should be held there, and apparently it is not.
> > 
> Yeah, my first solution was to add mmu_lock, but why function that gets
> vcpu as an input should destroy data structure that is global for the VM.

Point.

> There is kvm_mmu_zap_all() that does same thing (well almost) and also does
> proper locking. Shouldn't it be called during VM destruction instead?

Yes, that would better (which happens implicitly with mmu notifiers
->release).

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux