On 28/05/2015 03:46, Marcelo Tosatti wrote: > + flags = PVCLOCK_COUNTS_FROM_ZERO; If the KVM_FEATURE_CLOCKSOURCE_STABLE_BIT bit is not set, we cannot trust flags at all. So let's just do... > if (kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE_STABLE_BIT)) > - pvclock_set_flags(PVCLOCK_TSC_STABLE_BIT); > + flags |= PVCLOCK_TSC_STABLE_BIT; - pvclock_set_flags(PVCLOCK_TSC_STABLE_BIT); + pvclock_set_flags(~0); Otherwise looks good. Shall I do the above change and apply? Paolo > + pvclock_set_flags(flags); > + > + cpu = get_cpu(); > + vcpu_time = &hv_clock[cpu].pvti; > + flags = pvclock_read_flags(vcpu_time); > + if (flags & PVCLOCK_COUNTS_FROM_ZERO) > + set_sched_clock_stable(); > + put_cpu(); > } -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
