Re: [PATCH][RFC] KVM: PPC: fix suspicious use of conditional operator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2015-05-22 at 17:46 +0300, Laurentiu Tudor wrote:
> This was signaled by a static code analysis tool.
> 
> Signed-off-by: Laurentiu Tudor <Laurentiu.Tudor@xxxxxxxxxxxxx>
> ---
>  arch/powerpc/kvm/e500_mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kvm/e500_mmu.c b/arch/powerpc/kvm/e500_mmu.c
> index 50860e9..29911a0 100644
> --- a/arch/powerpc/kvm/e500_mmu.c
> +++ b/arch/powerpc/kvm/e500_mmu.c
> @@ -377,7 +377,7 @@ int kvmppc_e500_emul_tlbsx(struct kvm_vcpu *vcpu, gva_t ea)
>  			| MAS0_NV(vcpu_e500->gtlb_nv[tlbsel]);
>  		vcpu->arch.shared->mas1 =
>  			  (vcpu->arch.shared->mas6 & MAS6_SPID0)
> -			| (vcpu->arch.shared->mas6 & (MAS6_SAS ? MAS1_TS : 0))
> +			| ((vcpu->arch.shared->mas6 & MAS6_SAS) ? MAS1_TS : 0)
>  			| (vcpu->arch.shared->mas4 & MAS4_TSIZED(~0));
>  		vcpu->arch.shared->mas2 &= MAS2_EPN;
>  		vcpu->arch.shared->mas2 |= vcpu->arch.shared->mas4 &

Reviewed-by: Scott Wood <scottwood@xxxxxxxxxxxxx>

Please send as non-RFC.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux