[BUG ?] MIPS: KVM: condition with no effect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi !

 Not sure if this is a bug or maybe a placeholder for
 something... so patch - but maybe someone that knows this code can
 give it a look.

arch/mips/kvm/emulate.c:emulation_result kvm_mips_complete_mmio_load()    
<snip>
2414         case 2:
2415                 if (vcpu->mmio_needed == 2)
2416                         *gpr = *(int16_t *) run->mmio.data;                
2417                 else
2418                         *gpr = *(int16_t *) run->mmio.data;
2419 
2420                 break;
<snip>

 either the if/else is not needed or one of the branches is wrong
 or it is a place-holder for somethign that did not get
 done - in which case a few lines explaining this would be 
 nice (e.g. like in arch/sh/kernel/traps_64.c line 59)

 line numbers refer to 4.1-rc2 

thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux