Andrew Jones <drjones@xxxxxxxxxx> writes: > On Wed, Apr 01, 2015 at 06:28:55PM +0200, David Hildenbrand wrote: >> > This is a precursor for later patches which will need to do more to >> > setup debug state before entering the hyp.S switch code. The existing >> > functionality for setting mdcr_el2 has been moved out of hyp.S and now >> > uses the value kept in vcpu->arch.mdcr_el2. >> > >> > This also moves the conditional setting of the TDA bit from the hyp code >> > into the C code. >> > >> > Signed-off-by: Alex Bennée <alex.bennee@xxxxxxxxxx> >> > >> > create mode 100644 arch/arm64/kvm/debug.c >> > >> > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h >> > index 41008cd..8c01c97 100644 >> > --- a/arch/arm/include/asm/kvm_host.h >> > +++ b/arch/arm/include/asm/kvm_host.h >> > @@ -242,5 +242,7 @@ static inline void kvm_arch_hardware_unsetup(void) {} >> > static inline void kvm_arch_sync_events(struct kvm *kvm) {} >> > static inline void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) {} >> > static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {} >> > +static inline void kvm_arch_setup_debug(struct kvm_vcpu *vcpu) {} >> > +static inline void kvm_arch_clear_debug(struct kvm_vcpu *vcpu) {} >> >> Do you really want to call these functions "kvm_arch.." although they are not >> defined for other arch and not triggered by common code? >> > > Agreed. If other arches want something similar we can rename/refactor > later. If these are arm-only functions, then we don't need the generic > prefix, which is actually even a bit confusing. They are arm only but I was keeping in mind the need to add guest debug to ARMv7 at some point. > > drew -- Alex Bennée -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html