On 23 March 2015 at 17:05, Alex Bennée <alex.bennee@xxxxxxxxxx> wrote: > As there is logic to deal with the difference between edge and level > triggered interrupts in the kernel we must ensure it knows the > configuration of the IRQs before we restore the pending state. > > Signed-off-by: Alex Bennée <alex.bennee@xxxxxxxxxx> > Acked-by: Christoffer Dall <christoffer.dall@xxxxxxxxxx> > > diff --git a/hw/intc/arm_gic_kvm.c b/hw/intc/arm_gic_kvm.c > index 0d20750..e2512f1 100644 > --- a/hw/intc/arm_gic_kvm.c > +++ b/hw/intc/arm_gic_kvm.c > @@ -370,6 +370,11 @@ static void kvm_arm_gic_put(GICState *s) > * the appropriate CPU interfaces in the kernel) */ > kvm_dist_put(s, 0x800, 8, s->num_irq, translate_targets); > > + /* irq_state[n].trigger -> GICD_ICFGRn > + * (restore targets before pending IRQs so we treat level/edge > + * correctly */ > + kvm_dist_put(s, 0xc00, 2, s->num_irq, translate_trigger); You don't seem to have acted on Christoffer's query in v4 about this comment... -- PMM -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
