On Wed, 2015-03-18 at 11:27 -0600, Alex Williamson wrote: > --- a/drivers/vfio/virqfd.c > +++ b/drivers/vfio/virqfd.c > +#define DRIVER_VERSION "0.1" > +#define DRIVER_AUTHOR "Alex Williamson <alex.williamson@xxxxxxxxxx>" > +#define DRIVER_DESC "IRQFD support for VFIO bus drivers" > +MODULE_VERSION(DRIVER_VERSION); > +MODULE_LICENSE("GPL v2"); > +MODULE_AUTHOR(DRIVER_AUTHOR); > +MODULE_DESCRIPTION(DRIVER_DESC); Why bother with those three defines? They're all used just once, aren't they? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html