On Wed, Mar 11, 2015 at 12:16:09PM +0100, Petr Matousek wrote:
> If data is read from PIC with invalid access size, the return data stays
> uninitialized even though success is returned.
>
> Fix this by always initializing the data.
>
> Signed-off-by: Petr Matousek <pmatouse@xxxxxxxxxx>
> Reported-by: Nadav Amit <nadav.amit@xxxxxxxxx>
> ---
> arch/x86/kvm/i8259.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c
> index cc31f7c..9541ba3 100644
> --- a/arch/x86/kvm/i8259.c
> +++ b/arch/x86/kvm/i8259.c
> @@ -507,6 +507,7 @@ static int picdev_read(struct kvm_pic *s,
> return -EOPNOTSUPP;
>
> if (len != 1) {
> + memset(val, 0, len);
> pr_pic_unimpl("non byte read\n");
> return 0;
> }
> --
> 1.7.4.4
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
