On Thu, Mar 05, 2009 at 04:34:38PM +0200, Gleb Natapov wrote: > There are many code/logic duplications throughout ioapic/lapic/msi device > emulation. Try to consolidate as much code as possible. > > --- > > Gleb Natapov (5): > Get rid of deliver_bitmask. > Change the way how lowest priority vcpu is calculated. > Consolidate ioapic/ipi interrupt delivery logic. > ioapic/msi interrupt delivery consolidation. > Make kvm_apic_set_irq() deliver all kinds of interrupts. Applied and pushed, thanks. There is one issue with the new low prio selection though. Say you have an interrupt whose load is shared between all vcpus in the guest. The first vcpu which has its counter overflowed will then handle the int load by itself until it approximates to the counter of the other vcpus. Same happens with cpu hotplug. Not sure that the best way is to fix that. Perhaps reset all online vcpus to 0 on overflow/cpu-hotplug ? Or max the counter to a smaller value like 64 or something. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
