On Mon, 09 Mar 2015 17:43:19 +1030 Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote: > "Michael S. Tsirkin" <mst@xxxxxxxxxx> writes: > > virtio-balloon: do not call blocking ops when !TASK_RUNNING > > > > Rusty, it seems you prefer a different fix for this issue, > > while Cornelia prefers mine. Maybe both me and Cornelia misunderstand the > > issue? I know you dealt with a ton of similar issues recently > > so you are more likely to be right, but I'd like to understand > > what's going on better all the same. Could you help please? > > In the longer run, we should handle failures from these callbacks. But > we don't need to do that right now. So we want the minimal fix. > > And an annotation is the minimal fix. The bug has been there for ages; > it's just the warning that is new (if we *always* slept, we would > spin, but in practice we'll rarely sleep). I don't think doing_io() in virtio-ccw will sleep often, although it might happen under loads that delay posting the interrupt. I understand why you'd like to do the minimal fix, and it's not likely that new problems start popping up now. So I'm OK with doing the annotation for 4.0 and more involved changes for 4.1. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
