Am 03.03.2015 um 22:42 schrieb Bandan Das:
> Christian Borntraeger <borntraeger@xxxxxxxxxx> writes:
>
>> halt_poll_ns is used only locally. Make it static.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
>> ---
>> virt/kvm/kvm_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
>> index 34310a8..58bc2a9 100644
>> --- a/virt/kvm/kvm_main.c
>> +++ b/virt/kvm/kvm_main.c
>> @@ -66,7 +66,7 @@
>> MODULE_AUTHOR("Qumranet");
>> MODULE_LICENSE("GPL");
>>
>> -unsigned int halt_poll_ns = 0;
>> +static unsigned int halt_poll_ns = 0;
>
> We should remove the initialization to zero. (Unfortunately,
> the usage pattern throughout the kernel code is not constant..)
Yes,
static unsigned int halt_poll_ns;
will do.
Paolo, Marcelo,
I can add v2 to the next s390 pull request as below if you like.
halt_poll_ns is used only locally. Make it static and remove
the initializer.
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 34310a8..58bc2a9 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -66,7 +66,7 @@
MODULE_AUTHOR("Qumranet");
MODULE_LICENSE("GPL");
-unsigned int halt_poll_ns = 0;
+static unsigned int halt_poll_ns;
module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
/*
Otherwise I will resend.
to
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
