On 26/02/2015 15:24, Thomas Huth wrote:
On Thu, 26 Feb 2015 14:58:18 +0800
Xiubo Li <lixiubo@xxxxxxxxxxxxxxxxxxxx> wrote:
WARNING: quoted string split across lines
+ printk(KERN_INFO "kvm: enabling virtualization on "
+ "CPU%d failed\n", cpu);
When fails to enable virtualization on CPUx for kvm, this log will
be output in only one line, and it will be a little confusing for us
to grep this log in kernel source code.
In some case, the user maybe using on script to searching the error
log in kernel source code, if so, won't it always fail?
So this patch fix this issue.
Signed-off-by: Xiubo Li <lixiubo@xxxxxxxxxxxxxxxxxxxx>
---
virt/kvm/kvm_main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index a109370..3f08716 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -2817,12 +2817,11 @@ static void hardware_enable_nolock(void *junk)
cpumask_set_cpu(cpu, cpus_hardware_enabled);
r = kvm_arch_hardware_enable();
-
if (r) {
cpumask_clear_cpu(cpu, cpus_hardware_enabled);
atomic_inc(&hardware_enable_failed);
- printk(KERN_INFO "kvm: enabling virtualization on "
- "CPU%d failed\n", cpu);
+ printk(KERN_INFO "kvm: enabling virtualization on CPU%d failed\n",
+ cpu);
You could use pr_info() here instead of printk(KERN_INFO, ...) to avoid
exceeding the 80 columns limit.
Thomas
Yes, agree.
I have fix this in another patch later, but i think i should fix it in
this patch at the same time.
Thanks very much,
BRs
Xiubo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
