On Wed, Mar 04, 2009 at 03:30:22PM +0200, Gleb Natapov wrote: > Use kvm_apic_match_dest() in kvm_get_intr_delivery_bitmask() instead > of duplicating the same code. Use kvm_get_intr_delivery_bitmask() in > apic_send_ipi() to figure out ipi destination instead of reimplementing > the logic. > > Signed-off-by: Gleb Natapov <gleb@xxxxxxxxxx> > --- > -struct kvm_vcpu *kvm_get_lowest_prio_vcpu(struct kvm *kvm, u8 vector, > - unsigned long *bitmap) > -{ > - struct kvm_lapic *apic; > - > - apic = kvm_apic_round_robin(kvm, vector, bitmap); > - if (apic) > - return apic->vcpu; > - return NULL; > + return vcpu1->arch.apic_arb_prio - vcpu2->arch.apic_arb_prio; > } Can you split the round robin logic change to a separate patch, and have only code unification in this? Also mind the tabs. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html