On Tuesday 03 March 2009 20:50:16 Marcelo Tosatti wrote: > On Mon, Mar 02, 2009 at 04:29:26PM +0800, Sheng Yang wrote: > > Try to figure out device capability in update_dev_cap(). Now we are only > > care about MSI capability. > > > > The function pci_find_cap_offset original function wrote by Allen for > > Xen. Notice the function need root privilege to work. This depends on > > libpci to work. > > > > Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx> > > Signed-off-by: Sheng Yang <sheng@xxxxxxxxxxxxxxx> > > --- > > qemu/hw/device-assignment.c | 29 +++++++++++++++++++++++++++++ > > qemu/hw/device-assignment.h | 1 + > > 2 files changed, 30 insertions(+), 0 deletions(-) > > > > diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c > > index c9a3b8e..fc05ac7 100644 > > --- a/qemu/hw/device-assignment.c > > +++ b/qemu/hw/device-assignment.c > > @@ -219,6 +219,35 @@ static void assigned_dev_ioport_map(PCIDevice > > *pci_dev, int region_num, (r_dev->v_addrs + region_num)); > > } > > > > +static uint8_t pci_find_cap_offset(struct pci_dev *pci_dev, uint8_t cap) > > +{ > > + int id; > > + int max_cap = 48; > > + int pos = PCI_CAPABILITY_LIST; > > Don't you need to handle cardbus capability list offset? I think cardbus and PCI bridge are out of our scope for now... Maybe we should prohibit from assigning them. -- regards Yang, Sheng -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html