Re: [PATCH 12/21] KVM: x86: MOV to CR3 can set bit 63

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2015-02-10 17:18, Paolo Bonzini wrote:
> On 10/02/2015 17:15, Jan Kiszka wrote:
>>>>  #define CR3_L_MODE_RESERVED_BITS 0xFFFFFF0000000000ULL
>>>> +#define CR3_PCID_INVD		 (1UL << 63)
>> 1ULL (for i386)
> 
> Already fixed:
> 
> commit cfaa790a3fb8a7efa98f4a6457e19dc3a0db35d3
> Author: Borislav Petkov <bp@xxxxxxx>
> Date:   Thu Jan 15 09:44:56 2015 +0100
> 
>     kvm: Fix CR3_PCID_INVD type on 32-bit
>     
>     arch/x86/kvm/emulate.c: In function ‘check_cr_write’:
>     arch/x86/kvm/emulate.c:3552:4: warning: left shift count >= width of type
>         rsvd = CR3_L_MODE_RESERVED_BITS & ~CR3_PCID_INVD;
>     
>     happens because sizeof(UL) on 32-bit is 4 bytes but we shift it 63 bits
>     to the left.
>     
>     Signed-off-by: Borislav Petkov <bp@xxxxxxx>
>     Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>

Ah, sorry. Your kvm-kmod queue lacked a source link update!

Is this queued for stable as well? It's not in 3.19 apparently.

> 
>> Paolo, there is no 32-bit test build anymore on your side, right?
> 
> Reinstating it has been on my todo list for a while.  But as of now
> I'm not doing 32-bit tests.

OK.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux