> -----Original Message----- > From: H. Peter Anvin [mailto:hpa@xxxxxxxxx] > Sent: Saturday, January 31, 2015 2:19 AM > To: Wu, Feng; tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; x86@xxxxxxxxxx; > gleb@xxxxxxxxxx; pbonzini@xxxxxxxxxx; dwmw2@xxxxxxxxxxxxx; > joro@xxxxxxxxxx; alex.williamson@xxxxxxxxxx; jiang.liu@xxxxxxxxxxxxxxx > Cc: eric.auger@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx > Subject: Re: [v3 21/26] x86, irq: Define a global vector for VT-d > Posted-Interrupts > > On 12/12/2014 07:14 AM, Feng Wu wrote: > > Currently, we use a global vector as the Posted-Interrupts > > Notification Event for all the vCPUs in the system. We need > > to introduce another global vector for VT-d Posted-Interrtups, > > which will be used to wakeup the sleep vCPU when an external > > interrupt from a direct-assigned device happens for that vCPU. > > > > Signed-off-by: Feng Wu <feng.wu@xxxxxxxxx> > > > > > #ifdef CONFIG_HAVE_KVM > > +void (*wakeup_handler_callback)(void) = NULL; > > +EXPORT_SYMBOL_GPL(wakeup_handler_callback); > > + > > Stylistic nitpick: we generally don't explicitly initialize > global/static pointer variables to NULL (that happens automatically anyway.) > > Other than that, > > Acked-by: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx> Thanks a lot for your review, Peter! Thanks, Feng ��.n��������+%������w��{.n�����o�^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
