On 28/01/2015 07:19, Wincy Van wrote: >> > >> > No need for this function and nested_cpu_has_virt_x2apic_mode. Just >> > inline them in their caller(s). Same for other cases throughout the series. >> > > Do you mean that we should also inline the same functions in the other > patches of this patch set? > I think these functions will keep the code tidy, just like the > functions as nested_cpu_has_preemption_timer, nested_cpu_has_ept, etc. Most of the functions are just used once. If you want to keep them, please place them all close to the existing ones. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html