On 08/01/2015 13:15, Andrej Manduch wrote: >>> >> - /* FIXME: this code should not know anything about vcpus */ > I don't want to sounds like I'm nitpicking. But I need to ask. Why is > this comment removed? Because the real point of the comment was that the code should not know anything about VCPU requests. But it's okay to call a function to tell the VCPU "we want you to call us back at kvm_inject_apic_timer_irqs". Paolo >>> >> - kvm_make_request(KVM_REQ_PENDING_TIMER, vcpu); >>> >> + kvm_set_pending_timer(vcpu); -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html