On 26/12/14 13:00, Peter Maydell wrote:
On 26 December 2014 at 08:05, Tiejun Chen <tiejun.chen@xxxxxxxxx> wrote:
We should avoid to set irqfd{} unconditionally.
Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
Is there a hot path that we use this on such that the difference
in code order matters at all?
thanks
-- PMM
IMHO the patch does not change anything even on hot-hot path.
the declaration 'struct kvm_irqfd irqfd = {};' will
result in memset inside.
Thus in order to achieve declared goal author should
declare
struct kvm_irqfd irqfd;
and perform
memset(&irqfd, 0, sizeof(irqfd));
later after the check.
Regards,
Den
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
