> -----Original Message----- > From: Paolo Bonzini [mailto:paolo.bonzini@xxxxxxxxx] On Behalf Of Paolo > Bonzini > Sent: Friday, December 19, 2014 8:00 PM > To: Wu, Feng; linux-kernel@xxxxxxxxxxxxxxx > Cc: iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx > Subject: Re: [v3 16/26] KVM: Make struct kvm_irq_routing_table accessible > > > > On 19/12/2014 03:19, Wu, Feng wrote: > >>> > > > >>> > > +#ifdef CONFIG_HAVE_KVM_IRQ_ROUTING > >>> > > + > >>> > > +struct kvm_irq_routing_table { > >>> > > + int chip[KVM_NR_IRQCHIPS][KVM_IRQCHIP_NUM_PINS]; > >>> > > + struct kvm_kernel_irq_routing_entry *rt_entries; > >>> > > + u32 nr_rt_entries; > >>> > > + /* > >>> > > + * Array indexed by gsi. Each entry contains list of irq chips > >>> > > + * the gsi is connected to. > >>> > > + */ > >>> > > + struct hlist_head map[0]; > >>> > > +}; > >>> > > + > >>> > > +#else > >>> > > + > >>> > > +struct kvm_irq_routing_table {}; > >> > > >> > If possible, just make this "struct kvm_irq_routing_table;" and pull > >> > this line to include/linux/kvm_types.h. > >> > > >> > Paolo > > Do you mean move the definition of struct kvm_irq_routing_table > > to include/linux/kvm_types.h and add a declaration here? > > Move > > struct kvm_irq_routing_table; > > to include/linux/kvm_types.h. In kvm_host.h, leave the #ifdef with the > full definition but drop the #else. > > Paolo Paolo, Thanks for the explanation. I notice that " struct kvm_irq_routing_table;" is already in include/linux/kvm_types.h. Thanks, Feng -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
