Certain device properties (e.g. the device node name, the compatible string), are available as a list of strings (separated by the null terminating character). Let the VFIO user query this type of properties. Signed-off-by: Antonios Motakis <a.motakis@xxxxxxxxxxxxxxxxxxxxxx> --- drivers/vfio/platform/properties.c | 43 +++++++++++++++++++++++++++++++++++++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/drivers/vfio/platform/properties.c b/drivers/vfio/platform/properties.c index 8b90465..39c6342 100644 --- a/drivers/vfio/platform/properties.c +++ b/drivers/vfio/platform/properties.c @@ -7,7 +7,48 @@ static int dev_property_get_strings(struct device *dev, char *name, unsigned *lenp, void __user *datap, unsigned long datasz) { - return -EINVAL; + const char **val; + int n, i, ret; + + *lenp = 0; + + n = device_property_read_string_array(dev, name, NULL, 0); + if (n < 0) + return n; + + val = kcalloc(n, sizeof(char*), GFP_KERNEL); + if (!val) + return -ENOMEM; + + ret = device_property_read_string_array(dev, name, val, n); + if (ret < 0) + goto out; + + ret = 0; + + for (i = 0; i < n; i++) { + size_t len = strlen(val[i]) + 1; + + if (datasz < len) { + ret = -EOVERFLOW; + while (i < n) + *lenp += strlen(val[i++]) + 1; + goto out; + } + + if (copy_to_user(datap, val[i], len)) { + ret = -EFAULT; + goto out; + } + + *lenp += len; + datap += len; + datasz -= len; + } + +out: + kfree(val); + return ret; } static int dev_property_get_uint(struct device *dev, char *name, -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html