On Friday 27 February 2009 07:59:27 Marcelo Tosatti wrote: > Hi Sheng, > > So for guest INTX interrupts the host interrupt is reenabled on ack from > the guest, which is nice. Now for guest MSI interrupts it keeps reenabling > the interrupt as fast as the work handler can run. > > Can you explain why it works this way? Why not disable interrupts > on the host in all cases and only reenable on ack? > Sorry for I didn't think it over... The direct reason is ack_irq binding with kvm_set_irq() which is unnecessary for MSI/MSI-X. But enable(msi) after EOI seems more proper here, though more changes are needed for MSI-X(seems we need one ack notifier for one vector in MSI-X). -- regards Yang, Sheng -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
