On Thursday 26 February 2009, Glauber Costa wrote:
> @@ -548,15 +548,13 @@ static int do_set_msr(struct kvm_vcpu *vcpu, unsigned index, u64 *data)
>
> static void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock)
> {
> - static int version;
> + int version = 1;
> struct pvclock_wall_clock wc;
> struct timespec now, sys, boot;
>
> if (!wall_clock)
> return;
>
> - version++;
> -
> kvm_write_guest(kvm, wall_clock, &version, sizeof(version));
>
> /*
Doesn't this mean that kvm_write_guest now writes an uninitialized value
to the guest?
I think what you need here is a 'static atomic_t version;' so you can
do an atomic_inc instead of the ++.
Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
