2014-11-13 18:57+0100, Andrew Jones: > On Thu, Nov 13, 2014 at 06:47:40PM +0100, Paolo Bonzini wrote: > > > > > > On 13/11/2014 18:46, Radim Krčmář wrote: > > > Yes, or add callbacks to sysfs writes that would schedule/cancel this > > > work. (But having a for_every_vm loop is quite ugly.) > > > > > > I'd be happy with a 'const kvmclock_periodic_sync'. > > > (Having useless timers is weird if we care about latencies.) > > > > I agree. > > > > yeah, I guess Marcelo's thought was that users may turn it > off with sysfs, but once off, it'll never get to come back. > In that case the original patch is perfectly fine as is. (Good point, I never thought of that.) 300 second "race", we'd want to have both under the 'if' at least. Explicitly cancelling is better IMO. (This would make more sense with the previously mentioned per-vm property, if we had those without ioctls, and if the toggle was turned read-only after it has been changed to 'N'.) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
