Re: [PATCH 08/21] KVM: x86: Reset FPU state during reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Nov 6, 2014, at 10:58, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
> 
> On 05/11/2014 21:31, Nadav Amit wrote:
>> You are correct, it does not appear clearly in the SDM, but that is what real hardware does.
>> If you look at bochs - http://code.metager.de/source/xref/bochs/bochs/cpu/init.cc - you’ll see they call
>> "BX_CPU_THIS_PTR xcr0.set32(0x1);” regardless to whether it is hardware or software reset (the latter happens on INIT).
> 
> Fair enough. :)
Thanks. It is turning harder to find references for the crazy x86 behaviour. :)

> 
> Does the patch in
> http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/129060 look good?

Yes. However, re-reviewing the patches both my patch and yours actually do something slightly different than the spec: they clear XMM8-15 and YMM[128:…] which should not happen on INIT according to the spec.

Fixing it might be a bit intrusive. What do you say?

Nadav--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux