Am 05.11.2014 11:07, schrieb Alexander Graf: > > > On 27.10.14 16:44, Jason J. Herne wrote: >> From: "Jason J. Herne" <jjherne@xxxxxxxxxxxxxxxxxx> >> >> Enable KVM_SET_CLOCK and KVM_GET_CLOCK ioctls on s390 for managing guest Time >> Of Day clock value. >> >> Signed-off-by: Jason J. Herne <jjherne@xxxxxxxxxxxxxxxxxx> >> Reviewed-by: David Hildenbrand <dahi@xxxxxxxxxxxxxxxxxx> > > I like it. > > Reviewed-by: Alexander Graf <agraf@xxxxxxx> Paolo, are you ok with that patch as well? If yes I will send it with the next bunch of s390 patches. PS: I remember that you were considering some different take on the interface: IIRC you suggest to have the same format in kvm_clock_data->clock as x86, and that we might want to use a flag and a new field in the padding area that then contains the TOD value. Now looking again at Documentation/virtual/kvm/api.txt I actually prefer Jasons implementation since the api does not mention the value/format/offset. It seems to be ns since boot, correct? So if any changes, I would prefer a small change to the documentation, that makes the meaning of clock explicit per architecture? Christian -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
