On Mon, Oct 27, 2014 at 8:16 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > Hi Antonios, > > On Mon, Oct 27, 2014 at 12:07 PM, Antonios Motakis > <a.motakis@xxxxxxxxxxxxxxxxxxxxxx> wrote: >> The virqfd functionality that is used by VFIO_PCI to implement interrupt >> masking and unmasking via an eventfd, is generic enough and can be reused >> by another driver. Move it to a separate file in order to allow the code >> to be shared. >> >> Also properly export virqfd_enable and virqfd_disable in the process. > > Alex will handle this, not me, but my personal preference is to avoid > doing things "in the process" because the small changes get lost in > the big patch. > > I'd rather see a strict move that changes no code at all (except > things like necessary Makefile changes), followed by a smaller patch > that does the additional stuff. > > Does "properly export" mean that those functions were previously > *improperly* exported and the way they used to be exported caused a > problem? Or does it just mean "export"? It just means "export", but you are right there is no reason why to export it in this patch. I will move it to one of the next patches. > > Bjorn > >> Signed-off-by: Antonios Motakis <a.motakis@xxxxxxxxxxxxxxxxxxxxxx> >> --- >> drivers/vfio/Makefile | 4 +- >> drivers/vfio/pci/vfio_pci_intrs.c | 213 ----------------------------------- >> drivers/vfio/pci/vfio_pci_private.h | 3 - >> drivers/vfio/virqfd.c | 214 ++++++++++++++++++++++++++++++++++++ >> include/linux/vfio.h | 28 +++++ >> 5 files changed, 245 insertions(+), 217 deletions(-) >> create mode 100644 drivers/vfio/virqfd.c -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
