Re: [PATCH] KVM: nVMX: Disable preemption while reading from shadow VMCS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 08/10/2014 21:19, Jan Kiszka ha scritto:
> > Ouch! I apologize if I missed this in the previous discussion but why do
> > we never get into this condition while running a Linux guest ?
> 
> Well, you need high load on the host, preemption at the "wrong" time,
> and some relevant difference between the still to-be-copied shadow vmcs
> fields between the proper vmcs and the real one that was used by KVM at
> that point. I don't think it is a Jailhouse-only issue, but other
> hypervisors may be less sensitive.

Indeed; in the particular case of the virtual interrupt pending bit it's
easy to see why it is not a problem for Linux guests:
handle_interrupt_window hardly does anything, you will just have a
useless KVM_REQ_EVENT request.

Running many different L2 guests (with an overcommitted host) should
expose it.  Note that the memory map and selectors are relatively
similar among similar guests, and the most scary fields (RIP and RSP),
are copied first when preemption is less likely.  It's possible that
moving them last would increase the chance of breakage.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux