> > > > Argh, lets try again: > > > > skip_pinned = true > > ------------------ > > > > mark page dirty, keep spte intact > > > > called from get dirty log path. > > > > skip_pinned = false > > ------------------- > > reload remote mmu > > destroy pinned spte. > > > > called from: dirty log enablement, rmap write protect (unused for pinned > > sptes) > > > > > > Note this behaviour is your suggestion: > > Yes, I remember that and I thought we will not need this skip_pinned > at all. For rmap write protect case there shouldn't be any pinned pages, > but why dirty log enablement sets skip_pinned to false? Why not mark > pinned pages as dirty just like you do in get dirty log path? Because if its a large spte, it must be nuked (or marked read-only, which for pinned sptes, is not possible). -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
