2014-10-06 18:29+0300, Nadav Amit: > On Oct 3, 2014, at 3:49 PM, Radim Krčmář <rkrcmar@xxxxxxxxxx> wrote: > > 2014-10-03 00:30+0300, Nadav Amit: > > Reviewed-by: Radim Krčmář <rkrcmar@xxxxxxxxxx> > > > >> +#define X2APIC_BROADCAST 0xFFFFFFFFul > > > > (int is better -- using long introduces an interesting feature with > > implicit retyping: (int)X2APIC_BROADCAST != X2APIC_BROADCAST, and we > > don't compile with -Wtype-limits to notice it. It poses no problem > > now, so I can change it in an inevitable cleanup series / convince lkml > > to endorse stricter warnings.) > Would unsigned int ease your mind? That would be perfect. > >> -int kvm_apic_match_physical_addr(struct kvm_lapic *apic, u16 dest) > >> +static int kvm_apic_broadcast(struct kvm_lapic *apic, u32 dest) > > > > (bool is better.) > Ok. I will do it for v3. I'm fine with v2, which is why the nitpicking was in parentheses. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
