On Mon, 6 Oct 2014 18:26:55 +0300 "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: > On Mon, Oct 06, 2014 at 05:20:55PM +0200, Cornelia Huck wrote: > > On Mon, 6 Oct 2014 18:10:51 +0300 > > "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: > > > > > This is in preparation to extending config changed event handling > > > in core. > > > Wrapping these in an API also seems to make for a cleaner code. > > > > > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > > --- > > > include/linux/virtio.h | 6 +++++ > > > drivers/virtio/virtio.c | 53 +++++++++++++++++++++++++++++++++++++++++++ > > > drivers/virtio/virtio_pci.c | 55 ++------------------------------------------- > > > 3 files changed, 61 insertions(+), 53 deletions(-) > > > > > > diff --git a/include/linux/virtio.h b/include/linux/virtio.h > > > index 3c19bd3..8df7ba8 100644 > > > --- a/include/linux/virtio.h > > > +++ b/include/linux/virtio.h > > > @@ -78,6 +78,7 @@ bool virtqueue_is_broken(struct virtqueue *vq); > > > /** > > > * virtio_device - representation of a device using virtio > > > * @index: unique position on the virtio bus > > > + * @failed: saved value for CONFIG_S_FAILED bit (for restore) > > > > Have you considered s/failed/saved_failed/ ? > > I kind of prefer the shorter name, your reviewed tag made me think > you don't cosider this too important? Indeed; if you prefer the short name, just keep it. > > > > * @dev: underlying device. > > > * @id: the device type identification (used to match it with a driver). > > > * @config: the configuration ops for this device. > > > > Otherwise, my > > > > Reviewed-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx> > > > > still stands. > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
