On Thu, Sep 11, 2014 at 9:37 PM, Andre Przywara <andre.przywara@xxxxxxx> wrote: > Anup, > > On 08/09/14 09:17, Anup Patel wrote: >> The VCPU target type KVM_ARM_TARGET_XGENE_POTENZA is available >> in latest Linux-3.16-rcX or higher hence register aarch64 target >> type for it. >> >> This patch enables us to run KVMTOOL on X-Gene Potenza host. > > Why do you need this still if the previous patch got rid of the need for > naming each and every CPU in kvmtool? > Do you care about kernels older than 3.12? I wouldn't bother so much > since you'd need a much newer kvmtool anyway. Yes, actually APM SW team uses 3.12 kernel. > > Can you consider dropping this patch then? > I'd rather avoid adding CPUs to this list needlessly from now on. I think lets keep this patch because there are quite a few X-Gene users using older kernel. Regards, Anup > > Regards, > Andre. > >> >> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@xxxxxxxxxx> >> Signed-off-by: Anup Patel <anup.patel@xxxxxxxxxx> >> --- >> tools/kvm/arm/aarch64/arm-cpu.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/tools/kvm/arm/aarch64/arm-cpu.c b/tools/kvm/arm/aarch64/arm-cpu.c >> index ce5ea2f..ce526e3 100644 >> --- a/tools/kvm/arm/aarch64/arm-cpu.c >> +++ b/tools/kvm/arm/aarch64/arm-cpu.c >> @@ -41,10 +41,17 @@ static struct kvm_arm_target target_cortex_a57 = { >> .init = arm_cpu__vcpu_init, >> }; >> >> +static struct kvm_arm_target target_potenza = { >> + .id = KVM_ARM_TARGET_XGENE_POTENZA, >> + .compatible = "arm,arm-v8", >> + .init = arm_cpu__vcpu_init, >> +}; >> + >> static int arm_cpu__core_init(struct kvm *kvm) >> { >> return (kvm_cpu__register_kvm_arm_target(&target_aem_v8) || >> kvm_cpu__register_kvm_arm_target(&target_foundation_v8) || >> - kvm_cpu__register_kvm_arm_target(&target_cortex_a57)); >> + kvm_cpu__register_kvm_arm_target(&target_cortex_a57) || >> + kvm_cpu__register_kvm_arm_target(&target_potenza)); >> } >> core_init(arm_cpu__core_init); >> > CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, > is for the sole use of the intended recipient(s) and contains information > that is confidential and proprietary to Applied Micro Circuits Corporation or its subsidiaries. > It is to be used solely for the purpose of furthering the parties' business relationship. > All unauthorized review, use, disclosure or distribution is prohibited. > If you are not the intended recipient, please contact the sender by reply e-mail > and destroy all copies of the original message. > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html