On 20.08.14 15:36, Mihai Caraman wrote: > Add setter functions for IVPR, IVOR2 and IVOR8 emulation in preparation > for ONE_REG support. > > Signed-off-by: Mihai Caraman <mihai.caraman@xxxxxxxxxxxxx> What about the other GIVORs? Also, I would prefer to have a common helper for IVOR setting that simply covers SPRN_GIVOR setting along the way. Something like void kvmppc_set_ivor(struct kvm_vcpu *vcpu, int irqprio_ivor, u16 new_ivor) { vcpu->arch.ivor[irqprio_ivor] = new_ivor; switch (irqprio_ivor) { case BOOKE_IRQPRIO_DATA_STORAGE: mtspr(SPRN_GIVOR2, new_ivor); break; ... } } which you can just call from all the IVOR setters. In fact, you can probably combine all of the ONE_REG handlers into a single handler that just does a quick table lookup for its irqprio. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html