Hi Paolo, On Thu, Aug 21, 2014 at 02:33:36PM +0200, Paolo Bonzini wrote: [...] >> return; >> @@ -7847,6 +7859,27 @@ static bool nested_get_vmcs12_pages(struct kvm_vcpu *vcpu, >> vmx->nested.apic_access_page = >> nested_get_page(vcpu, vmcs12->apic_access_addr); >> } >> + >> + if (nested_cpu_has(vmcs12, CPU_BASED_TPR_SHADOW)) { > >Missing PAGE_ALIGNED check. I should have spotted this before, so I >just fixed it and will commit the patch soon. > Maybe I misunderstand your comments "On real hardware you could point the virtual-APIC page to an invalid address." http://lists.openwall.net/linux-kernel/2014/08/07/344 >Thanks for your persistence! > Thanks for your great help. ;-) Regards, Wanpeng Li >Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html