2014-08-21 15:22+0200, Paolo Bonzini: > Il 21/08/2014 13:56, Radim Krčmář ha scritto: > > 2014-08-21 10:29+0200, Paolo Bonzini: > >> Il 20/08/2014 22:53, Radim Krčmář ha scritto: > >>> + TP_PROTO(int grow, unsigned int vcpu_id, int new, int old), > >> > >> s/int grow/bool grow/ (and similarly in TP_STRUCT__entry). > > > > Ok. > > (We are using 'int' for this in other tracepoints, so I guessed there is > > some hate agains bool.) > > Yeah, there are many ints, but there are also some bools. :) > > Of course "bool" is only a no-brainer if there is a clear direction to > use (e.g. "bool has_error"), and indeed this case is less obvious. But > there are some like this one (e.g. bool gpa_match). > > Keep the int if you prefer it that way. I actually like bool much better, but first few were only int and then I stopped looking ... -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
