Re: [PATCH] KVM: x86: Warn on APIC base relocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



CC’ing the KVM mailing list which I forgot.

On Aug 20, 2014, at 11:12 AM, Nadav Amit <namit@xxxxxxxxxxxxxxxxx> wrote:

> APIC base relocation is unsupported by KVM. If anyone uses it, the least should
> be to report a warning in the hypervisor. Note that kvm-unit-tests performs
> APIC base relocation, and causes the warning to be printed.
> 
> Signed-off-by: Nadav Amit <namit@xxxxxxxxxxxxxxxxx>
> ---
> arch/x86/kvm/lapic.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index 08e8a89..6655e20 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -1416,6 +1416,11 @@ void kvm_lapic_set_base(struct kvm_vcpu *vcpu, u64 value)
>  	apic->base_address = apic->vcpu->arch.apic_base &
>  			     MSR_IA32_APICBASE_BASE;
> 
> +	if ((value & MSR_IA32_APICBASE_ENABLE) &&
> +	     apic->base_address != APIC_DEFAULT_PHYS_BASE)
> +		printk_once(KERN_WARNING
> +			    "APIC base relocation is unsupported by KVM\n");
> +
>  	/* with FSB delivery interrupt, we can restart APIC functionality */
>  	apic_debug("apic base msr is 0x%016" PRIx64 ", and base address is "
>  		   "0x%lx.\n", apic->vcpu->arch.apic_base, apic->base_address);
> -- 
> 1.9.1
> 

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux