On 08/08/2014 04:51 PM, Stefan Hajnoczi wrote:
On Fri, Aug 08, 2014 at 10:55:17AM +0200, David Marchand wrote:
Looks good, a few minor comments:
diff --git a/contrib/ivshmem-client/Makefile b/contrib/ivshmem-client/Makefile
new file mode 100644
index 0000000..eee97c6
--- /dev/null
+++ b/contrib/ivshmem-client/Makefile
@@ -0,0 +1,29 @@
CCed Peter Maydell for a second opinion, I'd suggest hooking up to
QEMU's top-level ./Makefile. QEMU does not do recursive make.
The advantages of hooking up QEMU's Makefile are:
1. So that ivshmem client/server code is built by default (on supported
host platforms) and bitrot is avoided.
2. So that you don't have to duplicate rules.mak or any other build
infrastructure.
Ok, done.
But in this case, should we really keep the files in contrib/ ?
I used this directory but I am not too sure about this.
Maybe hw/misc/ivshmem/ would be better ?
The rest of your comments have been integrated in my tree.
Is it preferred to send fixes aside the original patches ? or should I
send a squashed version ?
(I suppose the former is better as it is easier to read).
Thanks Stefan.
--
David Marchand
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
