On Tue, 2014-08-05 at 21:44 -0600, Alex Williamson wrote:
> > ret = vfio_spapr_pci_eeh_open(vdev->pdev);
> > - if (ret) {
> > - vfio_pci_disable(vdev);
> > - goto error;
> > - }
> > + if (ret)
> > + pr_warn_once("EEH is not supported\n");
> > }
> >
> > return 0;
>
> Now the next question, what's the point of vfio_spapr_pci_eeh_open()
> returning a value? Couldn't it return void now and this warning can
> go into eeh specific code? Thanks,
In order to call vfio_pci_disable() when that happens ?
Cheers,
Ben.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
