Hi Christoffer,
On Thu, Jul 31, 2014 at 01:10:15PM +0100, Christoffer Dall wrote:
> On Tue, Jul 01, 2014 at 03:45:16PM +0100, Will Deacon wrote:
> > Now that we have a dynamic means to register kvm_device_ops, use that
> > for the ARM VGIC, instead of relying on the static table.
> >
> > Cc: Gleb Natapov <gleb@xxxxxxxxxx>
> > Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> > Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> > Cc: Christoffer Dall <christoffer.dall@xxxxxxxxxx>
> > Signed-off-by: Will Deacon <will.deacon@xxxxxxx>
> > ---
> > include/linux/kvm_host.h | 1 -
> > virt/kvm/arm/vgic.c | 156 +++++++++++++++++++++++------------------------
> > virt/kvm/kvm_main.c | 4 --
> > 3 files changed, 78 insertions(+), 83 deletions(-)
[...]
> > + if (ret) {
> > + kvm_err("Cannot register vgic CPU notifier\n");
> > + goto out_free_irq;
> > + }
> > +
> > + on_each_cpu(vgic_init_maintenance_interrupt, NULL, 1);
> > +
> > + /* Callback into for arch code for setup */
> > + vgic_arch_setup(vgic);
>
> close to ridiculous nit: but I would add a newline here since the
> comment doesn't really apply to the kvm_register_device_ops, but please
> don't make another revision just for this.
I'll repost this after the merge window anyway, so there's plenty of room
for pedantic, cosmetic changes!
Thanks,
Will
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
