On Jul 18, 2014, at 12:38 AM, Marcelo Tosatti <mtosatti@xxxxxxxxxx> wrote: > On Thu, Jul 17, 2014 at 08:18:03PM +0300, Nadav Amit wrote: >> Small question if I may regarding kvm_mmu_pin_pages: >> ... >> I understand that the current use-case is for pinning only few >> pages. Yet, wouldn't it be better (for performance) to check whether >> the gfn uses a large page and if so to skip forward, increasing >> gfn_offset to point to the next large page? > > Sure, that can be a lazy optimization and performed when necessary? > > (feel free to do it in advance if you're interested in doing it > now). I would do it once your patch is applied (I don’t see it in the queue). Thanks, Nadav
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail