On 07/23/2014 08:25 AM, Yang Hongyang wrote: > Add a migration capability 'colo'. If this capability is on, > The migration will never end, and the VM will be continuously > checkpointed. > > Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx> > --- > include/qapi/qmp/qerror.h | 3 +++ > migration.c | 6 ++++++ > qapi-schema.json | 5 ++++- > 3 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h > index 902d1a7..226b805 100644 > --- a/include/qapi/qmp/qerror.h > +++ b/include/qapi/qmp/qerror.h > @@ -166,4 +166,7 @@ void qerror_report_err(Error *err); > #define QERR_SOCKET_CREATE_FAILED \ > ERROR_CLASS_GENERIC_ERROR, "Failed to create socket" > > +#define QERR_COLO_UNSUPPORTED \ > + ERROR_CLASS_GENERIC_ERROR, "COLO is not currently supported, please rerun configure with --enable-colo option in order to support COLO feature" Unless you plan on using this message in more than one place, we prefer that you don't add new #defines here. Instead, just use error_setg with the message inline. > +++ b/qapi-schema.json > @@ -491,10 +491,13 @@ > # @auto-converge: If enabled, QEMU will automatically throttle down the guest > # to speed up convergence of RAM migration. (since 1.6) > # > +# @colo: The migration will never end, and the VM will instead be continuously > +# checkpointed. The feature is disabled by default. (since 2.1) You missed 2.1. This has to be since 2.2. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature