On Thu, 2014-07-10 at 12:16 +0200, Alexander Graf wrote: > On 10.07.14 11:34, Michael Ellerman wrote: > > We have two arrays in kvm_host_state that contain register values for > > the PMU. Currently we only create an asm-offsets symbol for the base of > > the arrays, and do the array offset in the assembly code. > > > > Creating an asm-offsets symbol for each field individually makes the > > code much nicer to read, particularly for the MMCRx/SIxR/SDAR fields, and > > might have helped us notice the recent double restore bug we had in this > > code. > > > > Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > > Acked-by: Alexander Graf <agraf@xxxxxxx> Thanks. > I still think this whole code path should just be C though. Yeah it probably should. cheers -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
